-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extract-turnin permissions #53
base: main
Are you sure you want to change the base?
Conversation
9d1b1c9
to
9f206d8
Compare
Hi @zakkak, do you have any idea why this test fails? I tried many things, but it seems I am missing something. |
.github/workflows/main.yml
Outdated
pull_request: | ||
paths: | ||
- 'src/**' | ||
- 'Makefile' | ||
- '.github/workflows/main.yml' | ||
|
||
- 'scripts/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 'scripts/**' | |
- 'scripts/**' | |
Let's keep the newline here :)
Nope, you will need to figure out which command is the one that fails and then see why. Maybe using |
9f206d8
to
d2b0487
Compare
d2b0487
to
039a37e
Compare
This PR grants only read-write permissions to the owner that calls
extract-turnin
and no permissions for group,others.umask 077
before file extraction begins.Closes Weak Permission Set for turnin_extract #23